Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitor mastername changes. #703

Closed
wants to merge 14 commits into from
Closed

Monitor mastername changes. #703

wants to merge 14 commits into from

Conversation

samof76
Copy link
Contributor

@samof76 samof76 commented Sep 3, 2024

Fixes #698 .

Changes proposed on the PR:

  • Added the disableMyMaster flag to sentinel spec and defaults to false(for backward compatibility)
  • Added the unit tests to test generation
  • Adding master.go to get the current master name when disableMyMaster is true

@samof76 samof76 requested a review from a team as a code owner September 3, 2024 15:27
@samof76 samof76 closed this Sep 4, 2024
@samof76
Copy link
Contributor Author

samof76 commented Sep 4, 2024

Duplicate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two different redis clusters in different namespaces interconnected. Production disturbed.
1 participant
@samof76